Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appstream-glib: fix missing ossp-uuid dependency #27286

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

lukaso
Copy link
Contributor

@lukaso lukaso commented Jan 3, 2025

Even though upsteam doesn't declare uuid as a dependency in appstream-glib, it won't start without ossp-uuid being installed.

Description

Even though upstream doesn't declare uuid as a dependency in appstream-glib, it won't start without ossp-uuid being installed.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.7.10 20G1427 x86_64
Command Line Tools 13.2.0.0.1.1638488800

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@mascguy for port appstream-glib.
@dbevans for port appstream-glib.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Jan 3, 2025
Copy link
Member

@mascguy mascguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Lukas!

Even though upsteam doesn't declare uuid as a dependency in appstream-glib, it won't start without ossp-uuid being installed.
@lukaso lukaso force-pushed the fix-appstream-glib branch from d983219 to 71109a3 Compare January 3, 2025 23:42
@lukaso lukaso requested a review from mascguy January 3, 2025 23:43
gnomesysadmins pushed a commit to GNOME/gimp-macos-build that referenced this pull request Jan 3, 2025
@mascguy mascguy merged commit 04549cc into macports:master Jan 4, 2025
2 of 3 checks passed
@lukaso lukaso deleted the fix-appstream-glib branch January 4, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

4 participants