nodejs{12,14,16,18,20,22}: Use configure.cxxflags-append correctly

[tuffnatty]

Description

devel/nodejs* ports use configure.cxx-append to add C++ compiler flags. They also use compiler.blacklist-append to blacklist incompatible XCode versions. In such a situation, if compiler.blacklist-append is not placed before the first configure.cxx-append, on Mojave it results in configure.cxx not being set to the fallback compiler while configure.cc is correctly using the fallback compiler.

Failure logs (choose an OS version in the Port Health panel, look for CXX=, compare with CC=):

• nodejs18 on Mojave
• nodejs20 on Mojave
• nodejs22 on Mojave, Catalina, and Big Sur

Solution: use configure.cxxflags-append instead.

While I was looking at this, I also re-enabled ccache usage, as the reports on V8 not liking ccache seem to be really outdated.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.14.6 18G9323 x86_64
Command Line Tools 10.3.0.0.1.1562985497

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL in commit message?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[macportsbot]

Notifying maintainers:
@ci42 for port nodejs12, nodejs14, nodejs16, nodejs18, nodejs20, nodejs22.

[kencu]

JFTR, I tried that first of course:

#26031 (comment)

but it would not build the test suite that way, and I had to change it to appending onto the CXX compiler instead.

It was building correctly for a while, and then things went kinda sideways with the nodejs port PR and I can't say what happened exactly after that. Might have gotten hosed up.

[kencu]

maybe we don't care about the test suite any more anyway. It crashed every single time I tried to run it, on every nodejs version.

Also, there are some reports that the nodejs ports that have been enabled for older systems are causing kernel panics:

https://trac.macports.org/ticket/71475

This is probably because the libuv embedded in these nodejs systems has not been modified to work properly on older systems like our libuv ports have been. I tried to see if I could get these nodejs ports to use our system libuv instead, but they would not.

The next step would be to go through each nodejs port and find the embedded libuv, and try to patch it according to what we do in the libuv port. But I have not got to that, nor has anyone else so far.

[tuffnatty]

OK, I'm trying to run the tests at the moment. If we really need configure.cxx-append, let's move compiler.blacklist-append above it so that the fallback CXX is selected correctly.

I can't test the systems before 10.7 mentioned in https://trac.macports.org/ticket/71475 , so let's leave it for later.

[tuffnatty]

Hi @kencu,
The tests do build successfully here on nodejs20 + Mojave. They do fail later when running, but they do so on a nodejs20 + Monterey with clean HEAD code as well, at the same place in the scripts.