Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lima: drop dependency on QEMU from macOS 14 onwards #27277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danchr
Copy link
Member

@danchr danchr commented Jan 3, 2025

Description

As of Lima 1.0.0, it no longer defaults to using QEMU. Since QEMU is a rather large dependency, we should not depend on needless, so I've dropped it from 14 onwards.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@halostatue for port lima.
@herbygillot for port lima.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Jan 3, 2025
@halostatue
Copy link
Contributor

Would it be better to have a variant (lima +qemu)?

@emcrisostomo
Copy link
Member

I agree with @halostatue here. Even the wording in the update Portfile is a little bit misleading: if I understand correctly, lima still uses qemu under certain circumstances (see VM types | Lima). I would align the Portfile notes with that, and create a +qemu variant for those who need it.

@halostatue
Copy link
Contributor

I think that this has nothing but good for most people (I currently don't need to run any x86 VMs and the long QEMU build time on macOS 15 is tedious —if, thankfully, infrequent).

The change has one major downside which will affect both lima and colima users (I don't use lima directly, only indirectly via colima) as put on the VM types page:

The vmType can be specified only on creating the instance. The vmType of existing instances cannot be changed.

Having a +qemu variant is good, but its use would require a source build for people who port install lima +qemu — which means a somewhat slower install especially if you don't have Go installed by default.

That is, I’m in favour, but whether we add a +qemu variant or just update the post-install notes to be clearer about when you might want to install qemu side-by-side, I think that there's some change required. I just don't know exactly what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.

5 participants