Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exprtk: new port submission #27251

Closed

Conversation

ArashPartow
Copy link

@ArashPartow ArashPartow commented Jan 1, 2025

Description

This PR is for adding new port for the ExprTk library - basing it on version 0.0.3

Type(s)
  • [x ] enhancement
Verification

@ArashPartow ArashPartow marked this pull request as ready for review January 1, 2025 00:14
math/exprtk/Portfile Outdated Show resolved Hide resolved
math/exprtk/Portfile Outdated Show resolved Hide resolved
math/exprtk/Portfile Outdated Show resolved Hide resolved
@reneeotten
Copy link
Contributor

when making these changes, please also update your commit message to follow our guidelines.
"portname: new port, version ..."

@ArashPartow ArashPartow changed the title Add exprtk port exprtk: new port submission Jan 4, 2025
@ArashPartow ArashPartow force-pushed the arashpartow/add_exprtk branch 2 times, most recently from f415431 to 2449c41 Compare January 4, 2025 06:16
@ArashPartow ArashPartow requested a review from reneeotten January 4, 2025 06:17
math/exprtk/Portfile Outdated Show resolved Hide resolved
math/exprtk/Portfile Outdated Show resolved Hide resolved
@ArashPartow ArashPartow force-pushed the arashpartow/add_exprtk branch from 2449c41 to 7632d61 Compare January 4, 2025 16:09
@ArashPartow ArashPartow requested a review from reneeotten January 4, 2025 16:10
math/exprtk/Portfile Outdated Show resolved Hide resolved
@ArashPartow ArashPartow force-pushed the arashpartow/add_exprtk branch from 7632d61 to ef4cfe3 Compare January 5, 2025 23:19
@ArashPartow ArashPartow requested a review from reneeotten January 5, 2025 23:20
@reneeotten reneeotten force-pushed the arashpartow/add_exprtk branch from ef4cfe3 to 643de3b Compare January 6, 2025 02:23
@reneeotten
Copy link
Contributor

reneeotten commented Jan 6, 2025

@ArashPartow it doesn't look like you actually tested building this as it will never work the way you submitted it.... I made a few changes and it at least starts not but there is a failure. I will start the CI build now and you can check what it complains about and fix things. I think I made the correct changes to the Makefile but please check; it seems very non-standard to me...

If you spend all the time compiling examples, you should probably also install them for the user; otherwise don't do it and just only copy the header file...

@ArashPartow
Copy link
Author

@reneeotten I wont be fixing those compiler issues as they are not valid errors. Thanks for the help but I will close this PR as it is not worth proceeding any further.

@ArashPartow ArashPartow closed this Jan 6, 2025
@ArashPartow ArashPartow deleted the arashpartow/add_exprtk branch January 6, 2025 06:49
@reneeotten
Copy link
Contributor

@reneeotten I wont be fixing those compiler issues as they are not valid errors. Thanks for the help but I will close this PR as it is not worth proceeding any further.

Really… so I am wasting my time helping you to get this PR to a state that it could be merged and you can’t be bothered fixing your code or Makefile to get it to build with Clang? Fine with me…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants