-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exprtk: new port submission #27251
exprtk: new port submission #27251
Conversation
when making these changes, please also update your commit message to follow our guidelines. |
f415431
to
2449c41
Compare
2449c41
to
7632d61
Compare
7632d61
to
ef4cfe3
Compare
ef4cfe3
to
643de3b
Compare
@ArashPartow it doesn't look like you actually tested building this as it will never work the way you submitted it.... I made a few changes and it at least starts not but there is a failure. I will start the CI build now and you can check what it complains about and fix things. I think I made the correct changes to the Makefile but please check; it seems very non-standard to me... If you spend all the time compiling examples, you should probably also install them for the user; otherwise don't do it and just only copy the header file... |
@reneeotten I wont be fixing those compiler issues as they are not valid errors. Thanks for the help but I will close this PR as it is not worth proceeding any further. |
Really… so I am wasting my time helping you to get this PR to a state that it could be merged and you can’t be bothered fixing your code or Makefile to get it to build with Clang? Fine with me… |
Description
This PR is for adding new port for the ExprTk library - basing it on version 0.0.3
Type(s)
Verification