bctoolbox, ortp: fix build for < 10.7

[barracuda156]

Description

Unbreak both ports for old systems.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL in commit message?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[barracuda156]

What is this??

Installing MacPorts
  curl: (28) Failed to connect to github.com port 443 after 75006 ms: Couldn't connect to server
  Fetching base failed: 0
  Extracting...
  tar: Error opening archive: Failed to open 'MacPorts-2.9.3-21.tar.bz2'

[markemer]

I mean, it doesn't break the 12, 13, and 14 builds. I've got no way to test if this works. If no objections come in soon, I'll merge it as it's no maintainer. Also, @barracuda156 if you want to take the maintainership over, feel free. (hint, hint 😄)

[reneeotten]

@barracuda156 did upstream agree and/or is willing to accept these patches?

[barracuda156]

@barracuda156 did upstream agree and/or is willing to accept these patches?

@reneeotten The only experimental patch here is a conditional dropping of redundant framework. How do you suggest it to be submitted to upstream?

P. S. There is no need to get a permission of upstream to fix their bug, like a missing header.

[reneeotten]

@barracuda156 did upstream agree and/or is willing to accept these patches?

@reneeotten The only experimental patch here is a conditional dropping of redundant framework. How do you suggest it to be submitted to upstream?

P. S. There is no need to get a permission of upstream to fix their bug, like a missing header.

Sure, you don't need permission from anyone and that is of course a correct change. But how do you expect me or anyone else to vet all patches you add here (or in other PRs for that matter). I see that you submitted them upstream to bctoolbox but they haven't responded. The patch-legacy.diff for ortp seems to have not been submitted -or at least there is no URL-. I don't know what it does and whether or not that is correct; that's the whole idea of sending it upstream and see if they agree with it.

[markemer]

I mean, anything for systems like 10.6/10.7 might but could be unlikely to be upstreamed.

[barracuda156]

The patch-legacy.diff for ortp seems to have not been submitted -or at least there is no URL-.

That one I can submit.

UPD. Done: BelledonneCommunications/ortp#22
Let’s see, maybe upstream suggest something better instead.

[barracuda156]

@reneeotten Bump