Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix param using NAME #71

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Fix param using NAME #71

merged 10 commits into from
Jul 3, 2024

Conversation

KSkwarczynski
Copy link
Member

@KSkwarczynski KSkwarczynski commented Jun 26, 2024 •
edited
Loading

Summary

  • Allow fixing params using name instead of index
  • Some docuemnation
  • Start using multihreading in ROOT I/O

##Fix param using NAME
Config I used
image

Print out:
PR

tl:dr I want to avoid this MESS:
image

ROOT Mulitherading

Before After

@KSkwarczynski
Big brain, allow fixing parameters using name instead of hardocing nu…
f094e30 
…mbers. Mainianing these hardcoded number in config was my torn
@KSkwarczynski KSkwarczynski self-assigned this Jun 26, 2024
@KSkwarczynski
Merge branch 'develop' of https://github.com/mach3-software/MaCh3 int…
79e1c1e 
…o feature_FixParamBasedOnName
@KSkwarczynski
Tidy docuemation a bit
d72ead6
@KSkwarczynski
Merge branch 'develop' of https://github.com/mach3-software/MaCh3 int…
d307004 
…o feature_FixParamBasedOnName
@KSkwarczynski
Tidy, more Doxy comments etc
6752293
@KSkwarczynski
Did some test with ROOT Implicit multihreading and it genrally help r…
9e731f7 
…educe processsign by half on a very simple tree, I imagine in more complex tree it will be more impactfull. In addition improve docuematnion
@KSkwarczynski
funny prinit out mistakes
6d70177
@KSkwarczynski
update docuematnion
9d78811
@KSkwarczynski
Merge branch 'develop' of https://github.com/mach3-software/MaCh3 int…
7081b9d 
…o feature_FixParamBasedOnName
@KSkwarczynski
Remove warninig related to system call on newer gcc, and furhter imrp…
2be8c0a 
…ove doxy docuemtniaton
@KSkwarczynski KSkwarczynski merged commit 945dce8 into develop Jul 3, 2024
2 checks passed
@KSkwarczynski KSkwarczynski deleted the feature_FixParamBasedOnName branch July 3, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KSkwarczynski KSkwarczynski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KSkwarczynski