Feature core 1.2.0 #235
Merged
Feature core 1.2.0 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etup of the functional parameters and subsequently haven't reorder when some systematics are being setup
…eters, best not to hide these in core as they're not used by the reweighting directly anyway
…reset, this would require re-running the whole setup which we currently don't support. Must be passed through the constructor
… can use pdg code instead
…e bin getting to be slightly better
…ture debugging, so they're not just initialised to random numbers. Also tiny indent fixes and adding a static cast from an enum to an int
…n whether osccov is null or not so you know if you want to do osc weights or not
…hcih affect a particular DetID
…oving nutype and oscnutype as we can calcualte this from the pdg codes
|
Hi @EdAtkin, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
github-actions
bot
added
Nu Osc/Xsec
…e_core_T2K Latest and greatest commits to develop
…ed this wasn't being flagged as an error in the core but popped up in the CI
…a the constructor now
KSkwarczynski
requested review from
henry-wallace-phys and
ewanwm
as code owners
…&& signal events is actually still 0
…into feature_core_T2K
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Getting develop up to date with changes that occurred for v1.2.0. This is mainly changes to the remove the nutype and oscnutype from the samplePDFFDBase object and replacing with an event-by-event level vector of pdg codes for before and after oscillation (longer term this will eliminate the need to split the MC files by oscillation channel). There is an additional handy function for getting the spline interpolation type from the DetID which is handy for the spline loading for the FD. Also there is a bug-fix where DetID was not being initialised correctly. Small fix for reading in the spline binning as well for different delimiters.
Changes or fixes
Examples