WAIC #230
Open
WAIC #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
github-actions
bot
added
Documentation
…igng thus WAIC is no longer negative
clarenc3
reviewed
Dec 2, 2024
mcmc/SampleSummary.cpp
Outdated
| // **************** | ||
| MACH3LOG_INFO("******************************"); | ||
| switch(Criterion) { | ||
| // TSpline3 (third order spline in ROOT) |
clarenc3
reviewed
Dec 2, 2024
| @@ -2615,7 +2541,61 @@ void SampleSummary::StudyDIC() { | |||
| const double DIC_stat = Dhat + 2 * p_D; | |||
| MACH3LOG_INFO("Effective number of parameters following DIC formalism is equal to: {:.2f}", p_D); | |||
| MACH3LOG_INFO("DIC test statistic = {:.2f}", DIC_stat); | |||
| MACH3LOG_INFO("******************************"); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Since you refer to "equation 3" later on in the code, please put the reference in the header before the function declaration, or here in the implementation before the function declaration
There was a problem hiding this comment.
They are in header file this way it should be readable in doxygen
Line 153 in 01451f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Implement WAIC based on Gellman paper
https://arxiv.org/pdf/1307.5928
Changes or fixes
-Extend usage of vectors instead of raw pointers
Examples
Using some dummy values I obtained WAIC very similiar to DIC. It make sense both methods give similair results
[Edit]
WAIC after Fix