Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly ignore C-style cast in CUDA header, short int->int to avoid… #209

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Correctly ignore C-style cast in CUDA header, short int->int to avoid… #209

merged 4 commits into from
Nov 7, 2024

Conversation

henry-wallace-phys
Copy link
Contributor

… information loss in type conversion

Pull request description

Fixes to ensure compilation with CUDA

Changes or fixes

-> Fix typo when ignoring warnings from CUDA header
-> Fix int->short int conversion

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Hi @henry-wallace-phys, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions bot added Nu Osc/Xsec Related with neutrino interactions or oscialtions Manager GPU labels Nov 7, 2024
@KSkwarczynski
Copy link
Member

You copy int into short int?

MaCh3/splines/gpuSplineUtils.cu

Line 61 in c919f70

__device__ __constant__ short int d_spline_size;

this need fixing

dbarrow257
dbarrow257 reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@dbarrow257 dbarrow257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why we can't use the short int which was used previously?

dbarrow257
dbarrow257 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@dbarrow257 dbarrow257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbarrow257 dbarrow257 merged commit 66a293b into develop Nov 7, 2024
10 checks passed
@dbarrow257 dbarrow257 deleted the patches/hwallace/more_cuda_compile_fixes branch November 7, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarrow257 dbarrow257 dbarrow257 approved these changes

@KSkwarczynski KSkwarczynski Awaiting requested review from KSkwarczynski KSkwarczynski is a code owner

Assignees
No one assigned
Labels
GPU Manager Nu Osc/Xsec Related with neutrino interactions or oscialtions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henry-wallace-phys @KSkwarczynski @dbarrow257