Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added to classic_api #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Honestpuck
Copy link
Contributor

I wrote the methods for the network_segment endpoint.

Comment on lines 183 to 189
self.get_computer_by_id, [{"computer": i, "subsets": subsets} for i in computers]
self.get_computer_by_id,
[{"computer": i, "subsets": subsets} for i in computers],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check that you are using the formatting settings in the project? It looks like black is shortening lines to the default 88 characters when the project file is set to 100.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have black and ruff running from the project's virtual environment they should pick up the correct settings automatically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rebuild my .venv I probably did something to break it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a problem with format on save in my VS Code. I'll figure it out on the weekend,

Why black didn't pick it up is another question. Maybe it doesn't unfold sort lines it just folds long ones.

I got black to fix the file.

@brysontyrrell
Copy link
Collaborator

This PR needs to be updated with the latest changes from main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants