forked from voila-dashboards/voila
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
WIP feat: progressively load the widgets while the kernel is executing
This will connect to the kernel as soon as possible, and tries to create widget during execution. This avoids having to get all the widgets after execution, and is an alterative to; voila-dashboards#766 Issues: * since the whole jupyter message handling is 'synchronous' it awaits at a top level and goes all the way down, get_model needs to be resolved without any new message coming from the kernel. * Despite making handle_comm_open not returning a promise, we still get a stalling of the whole message q. Despite these issues, the loading time is significantly reduced, since the page renders almost instantly when it succeeds (e.g. when no widgets are missed).
- Loading branch information
1 parent
4d72fb2
commit 13fe75d
Showing
2 changed files
with
40 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters