refactor: Migrate Identity API Client to TypeScript #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
changed the title
alexs-mparticle
force-pushed
the
refactor/SQDSDKS-6679-migrate-identity-api-client-typescript
branch
3 times, most recently
from
7a613e8 to
8a2e225
Compare
rmi22186
requested changes
Nov 14, 2024
alexs-mparticle
force-pushed
the
refactor/SQDSDKS-6679-migrate-identity-api-client-typescript
branch
from
5864e6f to
cc84d6f
Compare
rmi22186
requested changes
Nov 20, 2024
src/identityApiClient.ts
Outdated
| false | ||
| ); | ||
| } catch (err) { | ||
| const errorMessage = (err as Error).message || 'Unknown Error'; |
There was a problem hiding this comment.
I think Unknown error is too generic. While we will know it is only coming from here if we do a global search for it, it might be more helpful to provide more context.
I actually think here is a good instance to do something like a toString which you had before if there is no message. That will allow us to debug further. What do you think?
There was a problem hiding this comment.
I think I would prefer err.toString() if error.message is not available.
alexs-mparticle
force-pushed
the
development
branch
from
b6883b6 to
b8a1a8f
Compare
alexs-mparticle
changed the base branch from
development
to
refactor/ts-migration-blackout-2024
alexs-mparticle
force-pushed
the
refactor/SQDSDKS-6679-migrate-identity-api-client-typescript
branch
from
fcb96db to
3d03859
Compare
|
alexs-mparticle
merged commit 68a0fee
into
refactor/ts-migration-blackout-2024
30 of 35 checks passed
rmi22186
pushed a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)