Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent caching of UIs #837

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

rmi22186
Copy link
Member

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

There were a few items on the xhr.responseText that we never use. Rather than cache everything, just cache the items we need.

Testing Plan

  • Was this tested locally? If not, explain why.
    Updated unit tests
    Tested on local sample app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rmi22186 rmi22186 merged commit bb52159 into development Jan 30, 2024
28 checks passed
@rmi22186 rmi22186 deleted the fix/SQDSDKS-6103-do-not-cache-ids branch April 8, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants