Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add browserstack testing #823

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

rmi22186
Copy link
Member

@rmi22186 rmi22186 commented Jan 3, 2024

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

These 6 commits have previously been approved. This branch was rebased with development, and we are now merging this to development.

Testing Plan

  • Was this tested locally? If not, explain why.
    Locally ran tests and also ran browserstack tests.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

on: [push, pull_request, workflow_dispatch]

jobs:
ubuntu-job:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about why we're calling this ubuntu-job. Are we planning on having other jobs for different OSes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

35 New issues
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

@rmi22186 rmi22186 merged commit e0a8a47 into development Jan 4, 2024
28 checks passed
@rmi22186 rmi22186 deleted the ci/SQDSDKS-5780-cross-browser-testing-rebase branch January 4, 2024 16:30
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 2.23.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants