-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cache identity responses #819
Merged
rmi22186
merged 13 commits into
feat/SQDSDKS-5976-identity-caching-feature-branch
from
feat/SQDSDKS-5976-identity-caching
Jan 22, 2024
Merged
feat: Cache identity responses #819
rmi22186
merged 13 commits into
feat/SQDSDKS-5976-identity-caching-feature-branch
from
feat/SQDSDKS-5976-identity-caching
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
commented
Dec 22, 2023
rmi22186
commented
Dec 22, 2023
rmi22186
commented
Dec 22, 2023
rmi22186
force-pushed
the
feat/SQDSDKS-5976-identity-caching-feature-branch
branch
from
January 9, 2024 20:05
8d955f2
to
8c84e26
Compare
rmi22186
force-pushed
the
feat/SQDSDKS-5976-identity-caching
branch
from
January 10, 2024 22:33
a19c697
to
c8da08b
Compare
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
rmi22186
commented
Jan 19, 2024
alexs-mparticle
requested changes
Jan 19, 2024
rmi22186
commented
Jan 22, 2024
Quality Gate failedFailed conditions 6.9% Duplication on New Code (required ≤ 3%) |
alexs-mparticle
approved these changes
Jan 22, 2024
rmi22186
merged commit Jan 22, 2024
5a59d66
into
feat/SQDSDKS-5976-identity-caching-feature-branch
25 of 28 checks passed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
development
Summary
We want to cache our identity responses to limit superfluous identity calls. This applies to login and identify for now. In this PR, I leveraged the vault in order to create a new
idCache
.The keys for the idCache are a concatenation of the identities being passed to it along with the
das
. An example value is as follows:When an identify or login call is attempted, the idCache is checked. If it is valid, we simply return the cached information, and do not make an identity call. If the key does not exist, or it has expired, then we fire another identity call, and cache that one.
Testing Plan
Integration tests. Unit tests.
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)