Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace individual type checks for customFlagProperty #813

Merged
merged 2 commits into from
Dec 20, 2023
Merged

refactor: Replace individual type checks for customFlagProperty #813

merged 2 commits into from
Dec 20, 2023

Conversation

alexs-mparticle
Copy link
Collaborator

@alexs-mparticle alexs-mparticle commented Dec 8, 2023 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Replace type checks for customFlagProperty with a utility function.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Send an upload via web sdk with custom flags that contain valid and invalid items, either as an array or not an array.
  • Invalid custom flags should be filtered out

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle requested review from rmi22186 and samdozor and removed request for samdozor December 8, 2023 17:53
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexs-mparticle alexs-mparticle changed the title refactor: Replacee individual type checks for customFlagProperty refactor: Replace individual type checks for customFlagProperty Dec 8, 2023
@alexs-mparticle alexs-mparticle merged commit 20a2e6a into development Dec 20, 2023
26 checks passed
alexs-mparticle added a commit that referenced this pull request Jan 2, 2024
@alexs-mparticle
refactor: Replace individual type checks for customFlagProperty (#813)
5dfd627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

@samdozor samdozor samdozor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexs-mparticle @samdozor @rmi22186