test: Refactor test set up for readability #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
requested changes
Nov 30, 2023
rollup.test.config.js
Outdated
| @@ -10,7 +10,7 @@ const extensions = ['.js', '.ts']; | |||
|
|
|||
| const builds = { | |||
| main: { | |||
| input: 'test/src/tests-main.js', | |||
| input: 'test/src/__test.index.ts', | |||
There was a problem hiding this comment.
Why the double underscore? It's not python, lol.
| @@ -8,7 +8,7 @@ import json from '@rollup/plugin-json'; | |||
|
|
|||
| export default [ | |||
| { | |||
| input: 'test/src/tests-main.js', | |||
| input: 'test/src/_index.ts', | |||
There was a problem hiding this comment.
Is it single or double?
Co-authored-by: Alex S <[email protected]>
alexs-mparticle
requested changes
Nov 30, 2023
alexs-mparticle
requested changes
Nov 30, 2023
alexs-mparticle
requested changes
Nov 30, 2023
| @@ -8,7 +8,7 @@ import json from '@rollup/plugin-json'; | |||
|
|
|||
| export default [ | |||
| { | |||
| input: 'test/src/tests-main.js', | |||
| input: 'test/src/_test.index.ts', | |||
There was a problem hiding this comment.
As per our conversation this morning, I thought we were just going to call this index.ts?
There was a problem hiding this comment.
Oh I thought we were just removing the underscore. If the idea is to eventually rename things to module.spec.ts like you have for vault.spec.ts, then once we have things higher alphabetically, it's better to keep it the underscore to keep it at the top of the folder.
Co-authored-by: Alex S <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
alexs-mparticle
approved these changes
Dec 1, 2023
rmi22186
merged commit f842ef5
into
ci/SQDSDKS-5780-cross-browser-testing
25 of 28 checks passed
rmi22186
added a commit
that referenced
this pull request
Jan 3, 2024
rmi22186
added a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
tests-main.js,config.js,utilsare all confusing names inside of a test folder. In order to make tests a bit more readable, these files have been reorganized and renamed.Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)