ci: Add Pre-release action to synchronize branches #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
commented
Nov 20, 2023
rmi22186
requested changes
Nov 21, 2023
Comment on lines
6
to
10
| dryRun: | ||
| description: 'Do a dry run to preview instead of a real release [true/false]' | ||
| required: true | ||
| type: boolean | ||
| default: true |
There was a problem hiding this comment.
nitpick - The term dryRun and the description isn't accurate here. Nothing is happening in the dryRun == true path, which I get is intentional - I'm being nitpicky about the variable name itself (and description). I'm not sure I have a better input here besides asking "Are you sure?" in this case.
Suggested change
| dryRun: | |
| description: 'Do a dry run to preview instead of a real release [true/false]' | |
| required: true | |
| type: boolean | |
| default: true | |
| dryRun: | |
| description: 'Type in false to push a specific version of the mParticle Web SDK to all branches' | |
| required: true | |
| type: boolean | |
| default: true |
Comment on lines
21
to
22
| # As a safe guard, if a valid release branch does not exist, | ||
| # this step will fail and throw an error |
There was a problem hiding this comment.
Suggested change
| # As a safe guard, if a valid release branch does not exist, | |
| # this step will fail and throw an error | |
| # As a safe guard, if a valid release branch does not exist, | |
| # this step will fail and throw an error. | |
| # Pushing previous versions of the SDK will require manual intervention. This action is not used for rollbacks. |
|
The commit name should also probably not be |
Co-authored-by: Robert Ing <[email protected]>
Co-authored-by: Robert Ing <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
rmi22186
approved these changes
Nov 21, 2023
alexs-mparticle
merged commit 69830ca
into
ci/SQDSDKS-5706-add-pre-release-action
24 of 26 checks passed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)