Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add legacy browsers for testing #800

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

rmi22186
Copy link
Member

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

To select browsers, I selected the version prior to what this page says supports ES6 in order to ensure the browsers would fail with any es6 code.

Safari and Edge were failing, so I incremented the versions until they passed, and then determined that those versions were still barely used and considered this to be sufficient.

Percentages were found by using these browsers have a combined ~.37% market share as of today, 11/14/2023. See www.browserlist.dev and quey for "opera < 38, safari < 12, chrome < 51, firefox <52, edge < 15"

Testing Plan

  • Was this tested locally? If not, explain why.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

test/cross-browser-testing/browserstack.karma.config.js Outdated Show resolved Hide resolved
test/src/tests-core-sdk.js Outdated Show resolved Hide resolved
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rmi22186 rmi22186 merged commit 392cf03 into ci/SQDSDKS-5792-cbt-GHA Nov 15, 2023
26 of 27 checks passed
@rmi22186 rmi22186 deleted the ci/SQDSDKS-5827-browser-selection branch November 17, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants