Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent immediate upload for UserAttributeChange Events #793

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix: Prevent immediate upload for UserAttributeChange Events #793

merged 2 commits into from
Oct 20, 2023

Conversation

alexs-mparticle
Copy link
Collaborator

@alexs-mparticle alexs-mparticle commented Oct 20, 2023 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Remove the reference to UserAttributeChanges as a trigger for immediate batch upload

Testing Plan

  • Was this tested locally? If not, explain why.
  • Using a sample application, increase the eventBatchingIntervalMillis value to something longer than 10 seconds.
  • Create a series of events and then attempt a UserAttributeChange
  • Verify that user attribute change event does not trigger an immediate upload.

Screenshot 2023-10-20 at 11 50 36 AM

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle changed the title Fix/sqdsdks 5886 prevent immediate upload for uac fix: Prevent immediate upload for UserAttributeChange Events Oct 20, 2023
@alexs-mparticle
Copy link
Collaborator Author

Closing and Reopening to re-run the checks

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexs-mparticle alexs-mparticle merged commit 2f0c5ac into development Oct 20, 2023
49 of 51 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 23, 2023
@mparticle-automation
chore(release): 2.23.7 [skip ci]
6ff3d54 
## [2.23.7](v2.23.6...v2.23.7) (2023-10-23)

### Bug Fixes

* Prevent immediate upload for UserAttributeChange Events ([#793](#793)) ([2f0c5ac](2f0c5ac))
* Respect sideloaded kit filter dictionaries ([#792](#792)) ([91b6afa](91b6afa))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 2.23.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexs-mparticle @mparticle-automation @rmi22186