Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Clean up Browserstack test files, remove unused files #788

Merged
merged 3 commits into from
Oct 17, 2023
Merged

ci: Clean up Browserstack test files, remove unused files #788

merged 3 commits into from
Oct 17, 2023

Conversation

rmi22186
Copy link
Member

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Now that we decided to go with Browserstack, I am cleaning up the CBT folder structure to be more generic.
  • Found that some files did not actually exist in the files array, or are not needed.
  • Removed test/runner.js which is not used anywhere.

Testing Plan

  • Was this tested locally? If not, explain why.
    Tested both local tests, as well as Browserstack tests and both run successfully.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rmi22186 rmi22186 merged commit 61d502b into ci/SQDSDKS-5780-cross-browser-testing Oct 17, 2023
24 of 26 checks passed
rmi22186 added a commit that referenced this pull request Oct 25, 2023
@rmi22186
ci: Clean up Browserstack test files, remove unused files (#788)
c3a125d
@rmi22186 rmi22186 deleted the ci/SQDSDKS-5797-clean-up-CBT branch November 17, 2023 21:18
rmi22186 added a commit that referenced this pull request Jan 3, 2024
@rmi22186
ci: Clean up Browserstack test files, remove unused files (#788)
3af9523
rmi22186 added a commit that referenced this pull request Jan 4, 2024
@rmi22186
ci: Clean up Browserstack test files, remove unused files (#788)
6a5a8f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexs-mparticle alexs-mparticle alexs-mparticle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmi22186 @alexs-mparticle