Unmap configUrl from direct silo

mParticle · Nov 6, 2023 · 5a3d1b3 · 5a3d1b3
1 parent 507c5d1
commit 5a3d1b3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/store.ts b/src/store.ts
@@ -497,6 +497,9 @@ export function processEndpoints(
         if (config.hasOwnProperty(endpointKey)) {
             endpoints[endpointKey] = config[endpointKey];
         } else {
+            if (endpointKey === 'configUrl') {
+                continue;
+            }
             var urlparts = endpoints[endpointKey].split('.');
 
             endpoints[endpointKey] = [

diff --git a/test/src/tests-core-sdk.js b/test/src/tests-core-sdk.js
@@ -1174,7 +1174,7 @@ describe('core SDK', function() {
 
             mParticle.init(apiKey, window.mParticle.config);
             mParticle.getInstance()._Store.SDKConfig.aliasUrl.should.equal(URLs[silo].aliasUrl);
-            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(URLs[silo].configUrl);
+            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(Constants.DefaultUrls.configUrl);
             mParticle.getInstance()._Store.SDKConfig.identityUrl.should.equal(URLs[silo].identityUrl);
             mParticle.getInstance()._Store.SDKConfig.v1SecureServiceUrl.should.equal(URLs[silo].v1SecureServiceUrl);
             mParticle.getInstance()._Store.SDKConfig.v2SecureServiceUrl.should.equal(URLs[silo].v2SecureServiceUrl);
@@ -1192,7 +1192,7 @@ describe('core SDK', function() {
 
             mParticle.init(apiKey, window.mParticle.config);
             mParticle.getInstance()._Store.SDKConfig.aliasUrl.should.equal(URLs[silo].aliasUrl);
-            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(URLs[silo].configUrl);
+            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(Constants.DefaultUrls.configUrl);
             mParticle.getInstance()._Store.SDKConfig.identityUrl.should.equal(URLs[silo].identityUrl);
             mParticle.getInstance()._Store.SDKConfig.v1SecureServiceUrl.should.equal(URLs[silo].v1SecureServiceUrl);
             mParticle.getInstance()._Store.SDKConfig.v2SecureServiceUrl.should.equal(URLs[silo].v2SecureServiceUrl);
@@ -1210,7 +1210,7 @@ describe('core SDK', function() {
 
             mParticle.init(apiKey, window.mParticle.config);
             mParticle.getInstance()._Store.SDKConfig.aliasUrl.should.equal(URLs[silo].aliasUrl);
-            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(URLs[silo].configUrl);
+            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(Constants.DefaultUrls.configUrl);
             mParticle.getInstance()._Store.SDKConfig.identityUrl.should.equal(URLs[silo].identityUrl);
             mParticle.getInstance()._Store.SDKConfig.v1SecureServiceUrl.should.equal(URLs[silo].v1SecureServiceUrl);
             mParticle.getInstance()._Store.SDKConfig.v2SecureServiceUrl.should.equal(URLs[silo].v2SecureServiceUrl);
@@ -1228,7 +1228,7 @@ describe('core SDK', function() {
 
             mParticle.init(apiKey, window.mParticle.config);
             mParticle.getInstance()._Store.SDKConfig.aliasUrl.should.equal(URLs[silo].aliasUrl);
-            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(URLs[silo].configUrl);
+            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(Constants.DefaultUrls.configUrl);
             mParticle.getInstance()._Store.SDKConfig.identityUrl.should.equal(URLs[silo].identityUrl);
             mParticle.getInstance()._Store.SDKConfig.v1SecureServiceUrl.should.equal(URLs[silo].v1SecureServiceUrl);
             mParticle.getInstance()._Store.SDKConfig.v2SecureServiceUrl.should.equal(URLs[silo].v2SecureServiceUrl);
@@ -1246,7 +1246,7 @@ describe('core SDK', function() {
 
             mParticle.init(apiKey, window.mParticle.config);
             mParticle.getInstance()._Store.SDKConfig.aliasUrl.should.equal(URLs[silo].aliasUrl);
-            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(URLs[silo].configUrl);
+            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(Constants.DefaultUrls.configUrl);
             mParticle.getInstance()._Store.SDKConfig.identityUrl.should.equal(URLs[silo].identityUrl);
             mParticle.getInstance()._Store.SDKConfig.v1SecureServiceUrl.should.equal(URLs[silo].v1SecureServiceUrl);
             mParticle.getInstance()._Store.SDKConfig.v2SecureServiceUrl.should.equal(URLs[silo].v2SecureServiceUrl);
@@ -1264,7 +1264,7 @@ describe('core SDK', function() {
 
             mParticle.init(apiKey, window.mParticle.config);
             mParticle.getInstance()._Store.SDKConfig.aliasUrl.should.equal(URLs[silo].aliasUrl);
-            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(URLs[silo].configUrl);
+            mParticle.getInstance()._Store.SDKConfig.configUrl.should.equal(Constants.DefaultUrls.configUrl);
             mParticle.getInstance()._Store.SDKConfig.identityUrl.should.equal(URLs[silo].identityUrl);
             mParticle.getInstance()._Store.SDKConfig.v1SecureServiceUrl.should.equal(URLs[silo].v1SecureServiceUrl);
             mParticle.getInstance()._Store.SDKConfig.v2SecureServiceUrl.should.equal(URLs[silo].v2SecureServiceUrl);

diff --git a/test/src/tests-store.ts b/test/src/tests-store.ts
@@ -288,8 +288,8 @@ describe('Store', () => {
                 );
 
                 const expectedResult = {
+                    configUrl: Constants.DefaultUrls.configUrl,
                     aliasUrl: "jssdks.us1.mparticle.com/v1/identity/",
-                    configUrl: "jssdkcdns.us1.mparticle.com/JS/v2/",
                     identityUrl: "identity.us1.mparticle.com/v1/",
                     v1SecureServiceUrl: "jssdks.us1.mparticle.com/v1/JS/",
                     v2SecureServiceUrl: "jssdks.us1.mparticle.com/v2/JS/",