fix: Resolve linting issues #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
commented
Nov 27, 2024
| } | ||
| } catch (ex: Exception) { | ||
| result.error(TAG, ex.message, null) | ||
| null | ||
| } |
There was a problem hiding this comment.
actually this is just a line formatting issue. i have fixed this. the builds from CI are all working, showing this isn't a syntax issue.
| } catch (ex: Exception) { | ||
| result.error(TAG, ex.message, null) | ||
| null | ||
| } | ||
| } | ||
|
|
||
|
|
rmi22186
force-pushed
the
fix/SQDSDKS-6259-flutter-lint
branch
from
c39b7c8 to
0be6142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Linter showed that there were several
Unchecked casterrors. This PR resolves them.Testing Plan
I manually tested events that included a product, impression, promotion event with custom attributes, as well as added CCPA to ensure all data was still sent properly with no crashes.
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)