Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type 'Null' is not a subtype of type 'String' in getCurrentUser #46

Merged

Conversation

Lukitaduarte
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Currently the mParticle SDK has a null pointer bug when trying to retrieve the mpid on some Android devices.

Testing Plan

  • I didn't test it locally, basically I just added a null check, an additional layer of protection to the existing check that only looks if the mpid is an empty string.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle requested a review from rmi22186 June 27, 2024 19:21
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the PR. While we never came across this in our testing, I agree this makes the code safer.

@rmi22186 rmi22186 merged commit c8073d1 into mParticle:development Jul 10, 2024
7 checks passed
@rmi22186
Copy link
Member

This has been published to pub.dev as version 1.0.5 - https://pub.dev/packages/mparticle_flutter_sdk

Thanks again for your help and apologies this took a bit longer than expected to approve. I had been out for a couple weeks.

@Lukitaduarte
Copy link
Contributor Author

@rmi22186 I appreciate it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants