-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Android project to Android Gradle Plugin 8.2 #43
chore: update Android project to Android Gradle Plugin 8.2 #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. some quick feedback below!
Thanks for talking the time to review it @rmi22186 😇 I've amended the code as requested. |
@rmi22186 looks like the build and test workflow is outdated; I'll try to fix it but it will probably need another approval from you to run |
@techouse yes i'll keep an eye on this PR! |
@rmi22186 ok, I have facelifted the example and fixed the CI
I have ALSO
|
@rmi22186 I fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much appreciated for your input here. Please see my fairly quick comments!
@rmi22186 I first decided to simply pin to the latest working version (current 3.19.3). Then I changed my mind to make a tl;dr I reverted back to a pinned version # pinned to latest stable version
FLUTTER_SDK_VERSION: 3.19.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you for the contribution!
Summary
android.namespace
package
from AndroidManifest.xmlcompileSdkVersion
to 34Testing Plan
Added this to pubspec.yaml