Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address firstInstall Edge Case #312

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

BrandonStalnaker
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker commented Nov 7, 2024

Summary

  • Deal with edge case that may have caused fewer first install reports than users

Testing Plan

  • Tested in local sample app. Could not recreate original issue but confirmed this change doesn't cause any new issues

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Nov 7, 2024
@BrandonStalnaker BrandonStalnaker force-pushed the fix/6899-Fix-FirstInstall-Edge-Case branch from 941ea38 to c46b857 Compare November 8, 2024 17:37
@BrandonStalnaker BrandonStalnaker force-pushed the fix/6899-Fix-FirstInstall-Edge-Case branch from c46b857 to 094ceb0 Compare November 8, 2024 18:19
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed over Zoom, this seems to be a reasonable potential solution.

@BrandonStalnaker BrandonStalnaker merged commit 3d18f8b into development Nov 13, 2024
11 checks passed
@BrandonStalnaker BrandonStalnaker deleted the fix/6899-Fix-FirstInstall-Edge-Case branch November 13, 2024 18:35
BrandonStalnaker added a commit that referenced this pull request Dec 2, 2024
* fix: Address firstInstall Edge Case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants