Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Initialize Kits in Background Thread #308

Merged

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • InitializeKits doesn't need to be called on the main thread

Testing Plan

  • Tested in simulator with several of our most used kits

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I feel a lot better about this with the dispatch to main for the kit delegate method calls

@BrandonStalnaker BrandonStalnaker merged commit 3f51ead into development Oct 30, 2024
11 checks passed
@BrandonStalnaker BrandonStalnaker deleted the refactor/6616-Initialize-Kits-in-Background branch October 30, 2024 12:11
BrandonStalnaker added a commit that referenced this pull request Nov 4, 2024
* refactor: Initialize Kits in Background Thread
mparticle-automation added a commit that referenced this pull request Nov 4, 2024
## [8.27.4](v8.27.3...v8.27.4) (2024-11-04)

### Bug Fixes

* Initialize Kits in Background Thread ([#308](#308)) ([38d3ea7](38d3ea7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants