refactor: Port MPILogger to Swift #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einsteinx2
requested changes
Sep 25, 2024
Comment on lines
15
to
18
| // Custom Logger is marked as nonnull despite the fact that we expect it to be null if not set by the client | ||
| // if let customLogger = MParticle.sharedInstance().customLogger { | ||
| // customLogger(msg) | ||
| // } else |
There was a problem hiding this comment.
Suggested change
| // Custom Logger is marked as nonnull despite the fact that we expect it to be null if not set by the client | |
| // if let customLogger = MParticle.sharedInstance().customLogger { | |
| // customLogger(msg) | |
| // } else |
I assume this was meant to be deleted?
There was a problem hiding this comment.
no I wanted to leave this here to make sure we understood this is kinda a todo once we fully convert to Swift
|
Addressed comments ready for a new look @einsteinx2 |
BrandonStalnaker
force-pushed
the
refactor/6733-Swift-Port-MPILogger
branch
from
574f54e to
2e9bb13
Compare
einsteinx2
approved these changes
Sep 30, 2024
|
🎉 This PR is included in version 8.27.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)