Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent Database Growth When ATT Status Denied #247

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • This change ensures that we never grow the database when ATT Status has been set to denied. Any Messages or Uploads already saved will remain until uploaded or service provides an invalid code

Testing Plan

  • Tested locally to confirm Denied ATT status blocks saving to the DB

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker
Copy link
Contributor Author

@einsteinx2 So the only issue I could find should identity.mparticle.com or nativesdks.mparticle.com be blocked is that the database could grow excessively large depending on what HTTP response a blocked URL returns. This change prevents that issue by blocking events from being saved to the DB. Currently, I'm only blocking save to the database when ATT Status is denied so that users not utilizing ATT Status won't see any change.

Personally I'm worried this change might be excessively cautious since events are already blocked at the Mparticle server level based on ATT status but it is what the ticket asked for and we can't be sure what HTTP response apple will give when blocking urls.

@BrandonStalnaker BrandonStalnaker marked this pull request as draft January 22, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant