Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove MPHasher C++ code and reduce number of ObjC++ files #233

Merged

Conversation

einsteinx2
Copy link
Contributor

Summary

  • Remove MPHasher C++ code and reduce number of ObjC++ files

Testing Plan

  • All unit tests show the same hashes being generated
  • Smoke tested using local test app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@einsteinx2 einsteinx2 force-pushed the chore/SQDSDKS-5906-refactor-out-mphasher-cpp-code branch from b4db9b5 to 1f8a607 Compare October 24, 2023 19:58
@einsteinx2
Copy link
Contributor Author

Note that this seems like a big PR but there are actually relatively few real changes.

@einsteinx2 einsteinx2 force-pushed the chore/SQDSDKS-5906-refactor-out-mphasher-cpp-code branch from 1f8a607 to 88aafb9 Compare October 24, 2023 20:29
@einsteinx2 einsteinx2 force-pushed the chore/SQDSDKS-5906-refactor-out-mphasher-cpp-code branch 2 times, most recently from 2f439e9 to b6c84a2 Compare October 24, 2023 22:45
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit 12b11ce into development Oct 25, 2023
11 checks passed
@einsteinx2 einsteinx2 deleted the chore/SQDSDKS-5906-refactor-out-mphasher-cpp-code branch October 25, 2023 14:15
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants