Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use direct url routing config feature flag #229

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat: Use direct url routing config feature flag #229

merged 1 commit into from
Oct 11, 2023

Conversation

einsteinx2
Copy link
Contributor

Summary

  • Reads the feature flag from the server config to decide whether to enable direct url routing or not (defaults to off if the key isn't included in the config)

Testing Plan

  • Tested using a QA environment with the feature flag present as well as tested against production without the feature flag to confirm it defaults to false
  • Confirmed that new installs will grab the config and have access to the feature flag before making more API calls

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

BrandonStalnaker
BrandonStalnaker approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit e862524 into feat/SQDSDKS-5764-api-url-routing-feature-branch Oct 11, 2023
14 of 15 checks passed
@einsteinx2 einsteinx2 deleted the feat/SQDSDKS-5777-direct-url-routing-server-config branch October 11, 2023 16:26
einsteinx2 added a commit that referenced this pull request Oct 11, 2023
@einsteinx2
feat: Direct routing to correct pod (#223) (#229) (#230)
14168f9 
* feat: Direct routing to correct pod (#223)

* feat: Use direct url routing config feature flag (#229)
mparticle-automation added a commit that referenced this pull request Oct 11, 2023
@mparticle-automation
chore(release): 8.16.0 [skip ci]
0bfe0b4 
# [8.16.0](v8.15.1...v8.16.0) (2023-10-11)

### Features

* Direct routing to correct pod ([#223](#223)) ([#229](#229)) ([#230](#230)) ([14168f9](14168f9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@markvdouw markvdouw Awaiting requested review from markvdouw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@einsteinx2 @BrandonStalnaker