Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Install events records for new users Edge case #528

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

Mansi-mParticle
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Investigated an issue where fewer "first install" events were being reported. I tried to reproduce the problem using two different samples in the same mParticle workspace but could not replicate it. However, I suspect it could be a race condition, where two threads in the app might be causing the issue. To fix this, I added synchronization to the method to prevent threading problems.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app and executed test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle merged commit 2f6b2bc into blackout-2024 Dec 17, 2024
20 of 23 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/SQDSDKS-6988-record-install-event branch December 17, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants