Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unused session history upload code #507

Merged

Conversation

einsteinx2
Copy link
Collaborator

Summary

Remove unused session history upload code. Confirmed that this hasn't been used for years and can be safely removed.

Testing Plan

  • Was this tested locally? If not, explain why.
  • All unit tests pass and E2E tested in a sample app to see batches still uploading correctly.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Review on live zoom call

@einsteinx2 einsteinx2 merged commit a86cd3b into development Sep 20, 2024
23 checks passed
@einsteinx2 einsteinx2 deleted the refactor/SQDSDKS-6788-remove-old-session-history-code branch September 20, 2024 18:17
mparticle-automation added a commit that referenced this pull request Oct 15, 2024
## [5.58.3](v5.58.2...v5.58.3) (2024-10-15)

### Updates & Maintenance

* Migrate Internal Constants class to kotlin  ([#510](#510)) ([2fd32f6](2fd32f6))
* Migrate MPLifecycleCallbackDelegate and MPLocationListener class to Kotlin ([#506](#506)) ([687e623](687e623))
* Remove unused session history upload code ([#507](#507)) ([a86cd3b](a86cd3b))
* Update submodules ([c0ffeb6](c0ffeb6))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.58.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Oct 24, 2024
## [5.58.3](v5.58.2...v5.58.3) (2024-10-24)

### Updates & Maintenance

* Migrate Internal Constants class to kotlin  ([#510](#510)) ([2fd32f6](2fd32f6))
* Migrate MPLifecycleCallbackDelegate and MPLocationListener class to Kotlin ([#506](#506)) ([687e623](687e623))
* Remove unused session history upload code ([#507](#507)) ([a86cd3b](a86cd3b))
* Update submodules ([81e50ca](81e50ca))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.58.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants