-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove unused session history upload code #507
Merged
einsteinx2
merged 5 commits into
development
from
refactor/SQDSDKS-6788-remove-old-session-history-code
Sep 20, 2024
Merged
refactor: Remove unused session history upload code #507
einsteinx2
merged 5 commits into
development
from
refactor/SQDSDKS-6788-remove-old-session-history-code
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
android-core/src/main/java/com/mparticle/internal/database/services/MParticleDBManager.java
Show resolved
Hide resolved
Mansi-mParticle
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Review on live zoom call
einsteinx2
deleted the
refactor/SQDSDKS-6788-remove-old-session-history-code
branch
September 20, 2024 18:17
mparticle-automation
added a commit
that referenced
this pull request
Oct 15, 2024
## [5.58.3](v5.58.2...v5.58.3) (2024-10-15) ### Updates & Maintenance * Migrate Internal Constants class to kotlin ([#510](#510)) ([2fd32f6](2fd32f6)) * Migrate MPLifecycleCallbackDelegate and MPLocationListener class to Kotlin ([#506](#506)) ([687e623](687e623)) * Remove unused session history upload code ([#507](#507)) ([a86cd3b](a86cd3b)) * Update submodules ([c0ffeb6](c0ffeb6))
🎉 This PR is included in version 5.58.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
mparticle-automation
added a commit
that referenced
this pull request
Oct 24, 2024
## [5.58.3](v5.58.2...v5.58.3) (2024-10-24) ### Updates & Maintenance * Migrate Internal Constants class to kotlin ([#510](#510)) ([2fd32f6](2fd32f6)) * Migrate MPLifecycleCallbackDelegate and MPLocationListener class to Kotlin ([#506](#506)) ([687e623](687e623)) * Remove unused session history upload code ([#507](#507)) ([a86cd3b](a86cd3b)) * Update submodules ([81e50ca](81e50ca))
🎉 This PR is included in version 5.58.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused session history upload code. Confirmed that this hasn't been used for years and can be safely removed.
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)