Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Certificate pinning update #504

Merged
merged 4 commits into from
Aug 21, 2024
Merged

feat: Certificate pinning update #504

merged 4 commits into from
Aug 21, 2024

Conversation

Mansi-mParticle
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Update Root Certificates

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with a sample app and used domain mapping to test Let's Encrypt certificates.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

einsteinx2
einsteinx2 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed approach and test cases with Mansi.

@Mansi-mParticle Mansi-mParticle merged commit 85b38cd into development Aug 21, 2024
24 checks passed
@Mansi-mParticle Mansi-mParticle deleted the feat/SQDSDKS-6546-cert-pinning branch August 21, 2024 16:54
mparticle-automation added a commit that referenced this pull request Aug 21, 2024
@mparticle-automation
chore: 5.58.0 (release)
a47804c 
## [5.58.0](v5.57.0...v5.58.0) (2024-08-21)

### Features

* Certificate pinning update ([#504](#504)) ([85b38cd](85b38cd))

### Updates & Maintenance

* Update submodules ([2c359eb](2c359eb))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.58.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@rmi22186 rmi22186 Awaiting requested review from rmi22186

@samdozor samdozor Awaiting requested review from samdozor

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mansi-mParticle @mparticle-automation @einsteinx2