Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Crash in KitConfiguration due to NumberFormatException #503

Merged
merged 3 commits into from
Aug 9, 2024
Merged

fix: Crash in KitConfiguration due to NumberFormatException #503

merged 3 commits into from
Aug 9, 2024

Conversation

Mansi-mParticle
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Fix rare crash in KitConfiguration caused by NumberFormatException. Updated code to handle NumberFormatException and null cases.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with the sample application and could not reproduce the issue initially. However, after adding a unit test, I was able to reproduce the issue and address it.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

einsteinx2
einsteinx2 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reviewed live on Zoom

@Mansi-mParticle Mansi-mParticle merged commit e1a23e7 into development Aug 9, 2024
23 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/SQDSDKS-6548-crash-config-response branch August 9, 2024 17:53
mparticle-automation added a commit that referenced this pull request Aug 13, 2024
@mparticle-automation
chore: 5.57.0 (release)
94284f5 
## [5.57.0](v5.56.5...v5.57.0) (2024-08-13)

### Features

* Support direct URL routing ([#499](#499)) ([d7aa30c](d7aa30c))

### Bug Fixes

* Crash in KitConfiguration due to NumberFormatException ([#503](#503)) ([e1a23e7](e1a23e7))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@samdozor samdozor Awaiting requested review from samdozor

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mansi-mParticle @mparticle-automation @einsteinx2 @rmi22186