refactor: Migrate Internal Constants class to kotlin (#510)

mParticle · Oct 3, 2024 · 2fd32f6 · 2fd32f6
1 parent a86cd3b
commit 2fd32f6
Show file tree

Hide file tree

Showing 6 changed files with 737 additions and 706 deletions.
diff --git a/android-core/src/main/java/com/mparticle/identity/IdentityApi.java b/android-core/src/main/java/com/mparticle/identity/IdentityApi.java
@@ -93,7 +93,7 @@ public MParticleUser getCurrentUser() {
      */
     @Nullable
     public MParticleUser getUser(@NonNull Long mpid) {
-        if (!Constants.TEMPORARY_MPID.equals(mpid) && mConfigManager.mpidExists(mpid)) {
+        if (Constants.TEMPORARY_MPID != mpid && mConfigManager.mpidExists(mpid)) {
             return MParticleUserImpl.getInstance(mContext, mpid, mUserDelegate);
         } else {
             return null;
@@ -252,7 +252,7 @@ public BaseIdentityTask modify(@NonNull final IdentityApiRequest updateRequest)
         if (updateRequest.mpid == null) {
             updateRequest.mpid = mConfigManager.getMpid();
         }
-        if (Constants.TEMPORARY_MPID.equals(updateRequest.mpid)) {
+        if (Constants.TEMPORARY_MPID == updateRequest.mpid) {
             String message = "modify() requires a non-zero MPID, please make sure a MParticleUser is present before making a modify request.";
             if (devMode) {
                 throw new IllegalArgumentException(message);

diff --git a/android-core/src/main/java/com/mparticle/internal/BatchId.java b/android-core/src/main/java/com/mparticle/internal/BatchId.java