Skip to content

Commit

Permalink
remove types-requests dependency (#420)
Browse files Browse the repository at this point in the history
Remove `types-requests` dependency because it interferes with the
`urllib` dependency

- [x] Ran `pre-commit run --all-files`
- [x] Local environment works as expected
  • Loading branch information
alejandroroiz authored Mar 6, 2024
1 parent b27ea00 commit f887328
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 17 deletions.
4 changes: 1 addition & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,10 @@ repos:
- id: mypy
additional_dependencies:
- --no-compile
- cffi==1.15.1
- cffi==1.14.6
- cryptography==41.0.1
- pycparser==2.21
- types-pyopenssl==23.2.0.1
- types-pytz==2023.3.0.0
- types-pyyaml==6.0.12.10
- types-redis==4.6.0.0
- types-requests==2.31.0.1
- types-urllib3==1.26.25.13
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.5.2
6.5.3
3 changes: 1 addition & 2 deletions requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ cryptography>2.3.0
# Upstream url: https://bitbucket.org/cffi/cffi
# Use: Required by cryptography package to be installed. This should be removed
# once crytography updates their depenencies to require cffi>=1.10.0.
cffi>1.10.0
cffi>1.10.0,<1.15.0

# License: BSD
# Upstream url: https://github.com/fengsp/flask-session
Expand Down Expand Up @@ -89,7 +89,6 @@ python3-saml>=1.15.0
# Upstream url: http://python-requests.org
# Use: REST calls to external services
requests>=2.22.0,<3.0.0
types-requests

# Provides enhanced HTTPS support for httplib and urllib2 using PyOpenSSL
# License: BSD
Expand Down
8 changes: 2 additions & 6 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# This file is autogenerated by pip-compile with Python 3.8
# by the following command:
#
# cd ~/src/confidant-private/upstream && run-piptools
# cd ~/src/confidant && run-piptools
#
async-timeout==4.0.2
# via redis
Expand All @@ -28,7 +28,7 @@ cerberus==1.3.4
# via -r requirements.in
certifi==2023.5.7
# via requests
cffi==1.15.1
cffi==1.14.6
# via
# -r requirements.in
# cryptography
Expand Down Expand Up @@ -186,10 +186,6 @@ types-pyyaml==6.0.12.10
# via -r requirements.in
types-redis==4.6.0.0
# via -r requirements.in
types-requests==2.31.0.1
# via -r requirements.in
types-urllib3==1.26.25.13
# via types-requests
typing-extensions==4.7.0
# via mypy
urllib3==1.25.11
Expand Down
6 changes: 1 addition & 5 deletions requirements3.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ cerberus==1.3.4
# via -r requirements.in
certifi==2023.5.7
# via requests
cffi==1.15.1
cffi==1.14.6
# via
# -r requirements.in
# cryptography
Expand Down Expand Up @@ -186,10 +186,6 @@ types-pyyaml==6.0.12.10
# via -r requirements.in
types-redis==4.6.0.0
# via -r requirements.in
types-requests==2.31.0.1
# via -r requirements.in
types-urllib3==1.26.25.13
# via types-requests
typing-extensions==4.7.0
# via mypy
urllib3==1.25.11
Expand Down
3 changes: 3 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ ignore_errors = true
ignore_errors = false
disallow_untyped_defs = false
disallow_incomplete_defs = false

[mypy-requests.*]
ignore_missing_imports = true

0 comments on commit f887328

Please sign in to comment.