-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for --dump-inputs #1159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! Very nice and clean implementation.
The only thing I'd add would be a unit and/or integration test, to make sure it produces the expected output. Let me know if you need some support with that, but I guess you got this.
Co-authored-by: Matthias Endler <[email protected]>
I added some integration tests in ac3fa41. I think this PR is now good to go! |
Great! I made a minor change to run the integration tests from a newly-created Hope that's fine. Looks good to me now. 😃 |
Yes, that's fine! Moving these test files into their folder for the obvious reasons you mentioned makes sense 😄 Thank you for merging this super quickly! EDIT: I created an upstream PR to test if a string contains all needles. This is especially useful when checking multiple lines of output. If this gets merged, we can simplify the tests quite a lot. |
Fixes #684
This PR adds support for the CLI flag
--dump-inputs
which prints out input sources without collecting and checking links.