readbility #285
Open
readbility #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It improves readability.
Make everything explicit. Also improves readability. Done by clang-tidy.
Increased readability.
tsujan
reviewed
Mar 9, 2021
tsujan
reviewed
Mar 9, 2021
| QPalette::ColorGroup colorGroup = (option.state & QStyle::State_Active) ? QPalette::Active : QPalette::Inactive; | ||
| if (option.state & QStyle::State_Selected) // selected items | ||
| QPalette::ColorGroup colorGroup = (option.state & QStyle::State_Active) != 0u ? QPalette::Active : QPalette::Inactive; | ||
| if ((option.state & QStyle::State_Selected) != 0u) // selected items |
There was a problem hiding this comment.
I really doubt that substitutions like the above ones could make the code more readable (there are some in other places too). I'm afraid I wanted to say the same thing about too much usage of nullptr but 0u might feel strange to code readers — especially if they're contributors who want to preserve the code style.
That being said, if you prefer them, there will be no objection from me.
There was a problem hiding this comment.
Will come back to you on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.