Set prgname to match the application id #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When launched on wayland with `WAYLAND_DEBUG=1` Liferea sets the app id "liferea" but not net.sourceforge.liferea: ``` [1225601.077] -> [email protected]_app_id("liferea") ``` When launched on KDE Wayland session, it expects the desktop file name to match the application id to look up the correct app icon to show in taskbar app swicther etc. But instead it tries too look up an icon called "liferea" which does not exist. So liferea shows up with the default wayland icon instead of the app icon. Setting WM_CLASS here won't work and we can't export two desktop files. This does not effect GNOME because it tries harder to guess the app icon
|
I think this was overlooked when everything was changed to match the app id in 0dea39b But actually the appid was I myself didn't notice this because I don't use KDE. But happened to see it when debugging the tray icon issue with flatpaks and testing it on KDE. This should not cause any change in behavior other than just setting the "correct" app id: The icons and desktop file are already named |
|
You can check the desktopFilename KDE plasma wayland expects by |
bbhtt
added a commit
to bbhtt/net.sourceforge.liferea
that referenced
this pull request
Oct 23, 2023
bbhtt
added a commit
to bbhtt/net.sourceforge.liferea
that referenced
this pull request
Oct 23, 2023
bbhtt
added a commit
to bbhtt/net.sourceforge.liferea
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launched on wayland with
WAYLAND_DEBUG=1Liferea sets the app id "liferea" but not net.sourceforge.liferea:When launched on KDE Wayland session, it expects the desktop file name to match the application id to look up the correct app icon to show in taskbar app switcher etc. But instead it tries too look up an icon called "liferea" which does not exist. So liferea shows up with the default wayland icon instead of the app icon.
Setting WM_CLASS here won't work and we can't export two desktop files.
This does not effect GNOME because it tries harder to guess the app icon.