Add profiler span labeler #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-at-luther
force-pushed
the
sam-at-luther/Add_profiler_fun_labeler
branch
from
30973c2 to
1206d25
Compare
lisp/x/profiler/funlabeler.go
Outdated
Comment on lines
53
to
67
| userLabel = sanitizeRegExp.ReplaceAllString(userLabel, "_") | ||
| // Ensure the label doesn't start with a digit or special character | ||
| if len(userLabel) > 0 && !unicode.IsLetter(rune(userLabel[0])) { | ||
| userLabel = "label_" + userLabel | ||
| } | ||
|
|
||
| // Eliminate duplicate underscores | ||
| parts := strings.Split(userLabel, "_") | ||
| var nonEmptyParts []string | ||
| for _, part := range parts { | ||
| if part != "" { | ||
| nonEmptyParts = append(nonEmptyParts, part) | ||
| } | ||
| } | ||
| return strings.Join(nonEmptyParts, "_") |
There was a problem hiding this comment.
This prefixing behavior seems a bit non-intuitive. Would it make sense to just drop leading junk we don't want to allow or reject the label entirely and fall back to the function name?
jeremy-asher
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.