-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include zstd compression & decompression in serde #203
base: main
Are you sure you want to change the base?
Conversation
Tests are broken since the generated ZStd file by the CLI does not match the one generated by serde. Not really sure why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! Just the tests failing, does the zstd cli need some args changed maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the formatting here changed on accident? This file should definitely be less than 80 wide (prettiers default) and not have to wrap across lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that must've been what happened - I ran prettier on root and it didn't respect the config perhaps?
I've tried most permutations of the arguments that I can pass to the CLI - async-compression's best mode corresponds on ZSTD's MAX_CLEVEL, which is 22 (I've read the source of both the crate and zstd to confirm this). |
Did you figure out what could be going on here? Not really sure myself but I also haven't looked too deeply into it. |
Unfortunately no :( Others in the lune channel could not figure it out either. |
According to the zstd CLI tool (downloaded from the zstd repo) the best compression level is 19. Are we sure that 22 is the max it uses? |
between 1 and 19; << In normal mode |
Closes #202.