Reduce images size #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
geoffroybouet
approved these changes
Oct 3, 2023
wjglerum
added a commit
that referenced
this pull request
Oct 4, 2023
* Update sbt to 1.9.2 (#60) * Update sbt to 1.9.3 (#61) * Update scala.yml * Create dependabot.yml * Bump actions/checkout from 2 to 3 (#63) Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-java from 2 to 3 (#62) Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2 to 3. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update asciidoctorj to 2.5.10 (#53) * Update sbt to 1.9.4 (#64) * Bump actions/checkout from 3 to 4 (#65) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update scala-library to 2.13.12 (#66) * Update sbt to 1.9.5 (#67) * Update play-json to 2.10.0 (#68) * Update sbt to 1.9.6 (#69) * Update play-json to 2.10.1 (#70) * Reduce images size (#71) * reduce image size by changing their resolution and using webp * avoid stretching people --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Lunatech Ops <[email protected]> Co-authored-by: Willem Jan Glerum <[email protected]> Co-authored-by: Willem Jan Glerum <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lunatech Ops <[email protected]> Co-authored-by: Aurélien Richez <[email protected]>
pepite
pushed a commit
that referenced
this pull request
Sep 2, 2024
* reduce image size by changing their resolution and using webp * avoid stretching people
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the image to webp and reduce their sizes to match the actual size of the place where we show them. I kept them at 500 px wide to account for high DPI screens.
I also changed a bit the css to use max-height. In the current state of things the images are stretched if they don't have the right format.
It seems that webp is supported widely know so it looks like a safe choice, but maybe I'm too optimistic ?