Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tail corrections to the energy and virial #54

Merged
merged 6 commits into from
Nov 27, 2016
Merged

Implement tail corrections to the energy and virial #54

merged 6 commits into from
Nov 27, 2016

Conversation

Luthaf
Copy link
Member

@Luthaf Luthaf commented Nov 17, 2016

The core logic is implemented here for energy and here for the virial, using the PairInteraction::tail_energy and PairInteraction::tail_virial functions.

This need a bit more tests, @g-bauer what was your strategy for checking against NIST data?

Fix #28

The choice to shift energy or not is left to the PairInteraction
structure
Two more functions are now needed to implement PairPotential
@g-bauer
Copy link
Contributor

g-bauer commented Nov 18, 2016

This need a bit more tests, @g-bauer what was your strategy for checking against NIST data?

I use the NIST reference calculations. I build an example, where the configurations offered by NIST are read and the system energy is calculated and checked vs. the values from NIST. I used the examples to test the energies without tail corrections. I'll send you the examples.

Regarding the PR, I think the name tail_virial is a bit misleading since you only use it to compute a correction to the pressure.

@Luthaf
Copy link
Member Author

Luthaf commented Nov 18, 2016

Regarding the PR, I think the name tail_virial is a bit misleading since you only use it to compute a correction to the pressure.

It is used in the computation of the Virial tensor, which in turn is used for the pressure.

I agree that the name Virial for this tensor is bad. It is more something like the virial contribution to the stress tensor. I'd like to improve the name, but I have no idea of a better one for the moment.

This only compare energy, tail correction and virial for a single LJ
configuration.
@Luthaf
Copy link
Member Author

Luthaf commented Nov 26, 2016

I added the test comparing against NIST, but a kind of potential is missing to compare with the LFS column.

Linear Force-shift potential can be added later (and are actually an easy thing to do), see issue #55 for this.

@Luthaf Luthaf merged commit e26c6c2 into master Nov 27, 2016
@Luthaf Luthaf deleted the tail branch November 27, 2016 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants