-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard backend #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good mostly, I think we may be able to clean up that one huge query a bit more, gave some suggestions to take a look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits and 1 question on behavior when no input for tornjak/agents/list
is provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* added api for tornjak agent info * agent selector fix and implementation of entryListByAgent api call * removed entryByAgent api call; added agent list input to tornjak agent metadata request * deleted manager entryByAgent call * cleaning up and commenting * nit fixes * restructured database to add agent entry whenever there is metadata * added tests * more nit fixes and handling of null cases Signed-off-by: Maia Iyer <[email protected]>
* added api for tornjak agent info * agent selector fix and implementation of entryListByAgent api call * removed entryByAgent api call; added agent list input to tornjak agent metadata request * deleted manager entryByAgent call * cleaning up and commenting * nit fixes * restructured database to add agent entry whenever there is metadata * added tests * more nit fixes and handling of null cases Signed-off-by: Maia Iyer <[email protected]>
* added api for tornjak agent info * agent selector fix and implementation of entryListByAgent api call * removed entryByAgent api call; added agent list input to tornjak agent metadata request * deleted manager entryByAgent call * cleaning up and commenting * nit fixes * restructured database to add agent entry whenever there is metadata * added tests * more nit fixes and handling of null cases Signed-off-by: Maia Iyer <[email protected]>
* added api for tornjak agent info * agent selector fix and implementation of entryListByAgent api call * removed entryByAgent api call; added agent list input to tornjak agent metadata request * deleted manager entryByAgent call * cleaning up and commenting * nit fixes * restructured database to add agent entry whenever there is metadata * added tests * more nit fixes and handling of null cases Signed-off-by: Maia Iyer <[email protected]>
No description provided.