Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard backend #75

Merged
merged 10 commits into from
Jul 20, 2021
Merged

Dashboard backend #75

merged 10 commits into from
Jul 20, 2021

Conversation

maia-iyer
Copy link
Collaborator

No description provided.

@maia-iyer
Copy link
Collaborator Author

@maia-iyer maia-iyer marked this pull request as ready for review July 12, 2021 19:42
@maia-iyer maia-iyer requested a review from lumjjb July 13, 2021 19:09
Copy link
Owner

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly, I think we may be able to clean up that one huge query a bit more, gave some suggestions to take a look at.

tornjak-backend/api/agent/api.go Outdated Show resolved Hide resolved
tornjak-backend/pkg/agent/db/sqlite_test.go Outdated Show resolved Hide resolved
tornjak-backend/pkg/agent/db/sqlite.go Outdated Show resolved Hide resolved
tornjak-backend/pkg/agent/types/agentinfo.go Outdated Show resolved Hide resolved
Copy link
Owner

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits and 1 question on behavior when no input for tornjak/agents/list is provided.

tornjak-backend/api/agent/server.go Outdated Show resolved Hide resolved
tornjak-backend/pkg/agent/db/sqlite.go Outdated Show resolved Hide resolved
tornjak-backend/pkg/agent/db/sqlite.go Outdated Show resolved Hide resolved
tornjak-backend/pkg/agent/db/sqlite.go Outdated Show resolved Hide resolved
tornjak-backend/pkg/agent/db/sqlite.go Outdated Show resolved Hide resolved
tornjak-backend/api/agent/api.go Show resolved Hide resolved
Copy link
Owner

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lumjjb lumjjb merged commit 1ed47f5 into lumjjb:main Jul 20, 2021
@maia-iyer maia-iyer linked an issue Aug 3, 2021 that may be closed by this pull request
3 tasks
lumjjb pushed a commit that referenced this pull request Aug 9, 2021
* added api for tornjak agent info

* agent selector fix and implementation of entryListByAgent api call

* removed entryByAgent api call; added agent list input to tornjak agent metadata request

* deleted manager entryByAgent call

* cleaning up and commenting

* nit fixes

* restructured database to add agent entry whenever there is metadata

* added tests

* more nit fixes and handling of null cases

Signed-off-by: Maia Iyer <[email protected]>
lumjjb pushed a commit that referenced this pull request Aug 9, 2021
* added api for tornjak agent info

* agent selector fix and implementation of entryListByAgent api call

* removed entryByAgent api call; added agent list input to tornjak agent metadata request

* deleted manager entryByAgent call

* cleaning up and commenting

* nit fixes

* restructured database to add agent entry whenever there is metadata

* added tests

* more nit fixes and handling of null cases

Signed-off-by: Maia Iyer <[email protected]>
lumjjb pushed a commit that referenced this pull request Aug 9, 2021
* added api for tornjak agent info

* agent selector fix and implementation of entryListByAgent api call

* removed entryByAgent api call; added agent list input to tornjak agent metadata request

* deleted manager entryByAgent call

* cleaning up and commenting

* nit fixes

* restructured database to add agent entry whenever there is metadata

* added tests

* more nit fixes and handling of null cases

Signed-off-by: Maia Iyer <[email protected]>
lumjjb pushed a commit that referenced this pull request Aug 9, 2021
* added api for tornjak agent info

* agent selector fix and implementation of entryListByAgent api call

* removed entryByAgent api call; added agent list input to tornjak agent metadata request

* deleted manager entryByAgent call

* cleaning up and commenting

* nit fixes

* restructured database to add agent entry whenever there is metadata

* added tests

* more nit fixes and handling of null cases

Signed-off-by: Maia Iyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Dashboard for organizational identity view
2 participants