Skip to content

Commit

Permalink
fix controller loading
Browse files Browse the repository at this point in the history
  • Loading branch information
2jammers committed Sep 21, 2024
1 parent f08fdd1 commit fb98c3c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
4 changes: 4 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Fixes an issue with controller loading

## [9.0.0-rc9] - 2024-09-21

### Fixed
Expand Down
8 changes: 4 additions & 4 deletions src/init.luau
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ end
[Learn More](https://luminlabsdev.github.io/framework/api/#start)
]=]
local function Start(loaded: { Types.Controller<any> }, callback: (() -> ())?)
Debugger.Assert(Started, "AlreadyStarted")
Debugger.Assert(not Started, "AlreadyStarted")

LoadAllControllers(loaded) -- Yields until they are loaded
StartCycles()
Expand All @@ -128,7 +128,7 @@ end
[Learn More](https://luminlabsdev.github.io/framework/api/#new)
]=]
local function New<T>(members: Types.Controller<T>): T
Debugger.Assert(Started, "AlreadyStarted")
Debugger.Assert(not Started, "AlreadyStarted")
table.insert(Storage.Controllers, members)
return members
end
Expand All @@ -139,8 +139,8 @@ end
[Learn More](https://luminlabsdev.github.io/framework/api/#cycle)
]=]
local function Cycle(type: Types.CycleType, callback: (...any) -> ())
Debugger.Assert(Started, "AlreadyStarted")
Debugger.Assert(not DefaultCycleTypes[type], "ItemNotFound", type)
Debugger.Assert(not Started, "AlreadyStarted")
Debugger.Assert(DefaultCycleTypes[type], "ItemNotFound", type)
if type == "PreRender" and not RunService:IsClient() then
Debugger.Fatal("IncorrectContext", "WorkerType")
end
Expand Down
4 changes: 2 additions & 2 deletions wally.toml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
[package]
name = "lumin/framework"
description = "A lightning fast & amazing game framework for Roblox"
version = "9.0.0-rc9"
version = "9.0.0-rc10"
license = "MIT"
registry = "https://github.com/UpliftGames/wally-index"
realm = "shared"

[dependencies]
debugger = "lumin/debugger@^0.3.0"
debugger = "lumin/debugger@^0.4.0"
spawn = "red-blox/spawn@^1.0.0"

[dev-dependencies]
Expand Down

0 comments on commit fb98c3c

Please sign in to comment.