Skip to content

Commit

Permalink
8.0.5
Browse files Browse the repository at this point in the history
  • Loading branch information
2jammers committed Jul 14, 2024
1 parent d1b1fcc commit 1ee370b
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 21 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/discord.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,18 @@ jobs:
if [ "${{ github.event_name }}" == "issues" ]; then
EVENT_URL="${{ github.event.issue.html_url }}"
EVENT_TITLE="${{ github.event.issue.title }}"
EVENT_BODY="${{ github.event.issue.body }}"
elif [ "${{ github.event_name }}" == "pull_request" ]; then
EVENT_URL="${{ github.event.pull_request.html_url }}"
EVENT_TITLE="${{ github.event.pull_request.title }}"
EVENT_BODY="${{ github.event.pull_request.body }}"
fi
EMBED_JSON=$(jq -n \
--arg title "$EVENT_TITLE" \
--arg url "$EVENT_URL" \
--arg description "$EVENT_BODY" \
--arg event_type "${{ github.event_name }}" \
'{
"embeds": [{
"title": $event_type,
"url": $url,
"description": $description
"title": $title,
"description": [View issue]($url),
}],
"thread_name": $title
'})
Expand Down
8 changes: 8 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

This is the changelog which is changed every update, and we follow semver.

## 8.0.5

### Improvements

- Fixes problems with .Load not working entirely correctly
- Fixes package list in docs
- Type validation will now error if incorrect

## 8.0.4

### Improvements
Expand Down
3 changes: 1 addition & 2 deletions docs/guides/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ From here, you can access run context specific items like the player gui.

To start a successful project, we recommend using:

`jsdotlua/react-lua`\
`jsdotlua/react-roblox`\
`lumin/aegis`\
`sleitnick/trove`

... and of course Lumin Framework.
6 changes: 2 additions & 4 deletions src/Network/Interface.luau
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,7 @@ function ServerEvent:Listen(func: (sender: Player, ...unknown) -> (), typeValida
if typeValidationArgs then
for index, value in args do
if typeof(value) ~= typeValidationArgs[index] then
warn(`[Lumin] Argument #{index} does not have the type '{typeValidationArgs[index]}'`)
return
error(`[Lumin] Argument #{index} does not have the type '{typeValidationArgs[index]}'`)
end
end
end
Expand Down Expand Up @@ -227,8 +226,7 @@ function ServerFunction:OnInvoke(
if typeValidationArgs then
for index, value in args do
if typeof(value) ~= typeValidationArgs[index] then
warn(`[Lumin] Argument #{index} does not have the type '{typeValidationArgs[index]}'`)
return
error(`[Lumin] Argument #{index} does not have the type '{typeValidationArgs[index]}'`)
end
end
end
Expand Down
19 changes: 12 additions & 7 deletions src/init.luau
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,24 @@ end

-- Loads any module that is within the provided parent, and then filtered if a function is given
-- Please note that these modules could load in any order, and that
local function Load(parent: Instance, filter: ((module: ModuleScript) -> boolean)?)
local function Load(container: Instance, filter: ((module: ModuleScript) -> boolean)?)
task.defer(function()
for _, module in parent:GetChildren() do
local Imported = {}
for _, module in container:GetChildren() do
if not module:IsA("ModuleScript") then
continue
end
if filter and filter(module) then
local imported = (require)(module)
if type(imported["Init"]) == "function" then
imported["Init"]()
end
if not filter or (filter and filter(module)) then
local ImportedModule = (require)(module)
table.insert(Imported, ImportedModule)
end
end
for _, module in Imported do
if module["Init"] and type(module.Init) == "function" then
module.Init()
end
end
table.clear(Imported)
end)
end

Expand Down
2 changes: 1 addition & 1 deletion wally.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "lumin/framework"
description = "A lightning fast & amazing game framework for Roblox"
version = "8.0.4"
version = "8.0.5"
license = "MIT"
registry = "https://github.com/UpliftGames/wally-index"
realm = "shared"
Expand Down

0 comments on commit 1ee370b

Please sign in to comment.