Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Create an NFT Collection using LSP8 tutorial #715

Merged
merged 15 commits into from
Nov 24, 2023
Merged

Add Create an NFT Collection using LSP8 tutorial #715

merged 15 commits into from
Nov 24, 2023

Conversation

biancabuzea200
Copy link
Contributor

No description provided.

@biancabuzea200 biancabuzea200 requested a review from Hugoo as a code owner November 8, 2023 10:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

Deployed with Cloudflare Pages ☁️ 🚀 🆗

fhildeb
fhildeb reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@fhildeb fhildeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick and easy guide. I like it. Added some comments for improvements.

@CJ42 what about porting the lukso-hardhat-template to lukso-network as we did with the erc725-inspect (hugo's) and playground (mine) repos

docs/learn/smart-contract-developers/create-nft-collection.md Outdated Show resolved Hide resolved
docs/learn/smart-contract-developers/create-nft-collection.md Outdated Show resolved Hide resolved
docs/learn/smart-contract-developers/create-nft-collection.md Show resolved Hide resolved
docs/learn/smart-contract-developers/create-nft-collection.md Outdated Show resolved Hide resolved
docs/learn/smart-contract-developers/create-nft-collection.md Outdated Show resolved Hide resolved
docs/learn/smart-contract-developers/create-nft-collection.md Outdated Show resolved Hide resolved
docs/learn/smart-contract-developers/create-nft-collection.md Show resolved Hide resolved
docs/learn/smart-contract-developers/create-nft-collection.md Outdated Show resolved Hide resolved
@Hugoo Hugoo changed the title create an NFT Collection using LSP8 Add Create an NFT Collection using LSP8 tutorial Nov 10, 2023
fhildeb
fhildeb approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@fhildeb fhildeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Great work. 👍🏻

@fhildeb fhildeb requested a review from Hugoo November 23, 2023 15:22
Hugoo
Hugoo suggested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@Hugoo Hugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a mismatch between file path and the example repo

docs/learn/smart-contract-developers/create-nft-collection.md Outdated Show resolved Hide resolved
docs/learn/smart-contract-developers/create-nft-collection.md Outdated Show resolved Hide resolved
@Hugoo
Copy link
Contributor

Hugoo commented Nov 23, 2023

Why is this not put in the Setup section of this doc?

image

Could you please put all the install in the setup part?

@Hugoo Hugoo mentioned this pull request Nov 23, 2023
Merged
@Hugoo Hugoo merged commit 8d558f8 into main Nov 24, 2023
2 checks passed
@Hugoo Hugoo deleted the noteDocs branch November 24, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhildeb fhildeb fhildeb approved these changes

@Hugoo Hugoo Hugoo approved these changes

@CJ42 CJ42 Awaiting requested review from CJ42

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@biancabuzea200 @Hugoo @CJ42 @fhildeb