Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update withdrawal key guide #700

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Update withdrawal key guide #700

merged 3 commits into from
Oct 31, 2023

Conversation

fhildeb
Copy link
Contributor

@fhildeb fhildeb commented Oct 31, 2023

No description provided.

@fhildeb fhildeb requested a review from Hugoo as a code owner October 31, 2023 12:05
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

Deployed with Cloudflare Pages ☁️ 🚀 🆗

Copy link
Contributor

@Hugoo Hugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

docs/networks/advanced-guides/withdrawal-update.md Outdated Show resolved Hide resolved
3. Send the JSON file to the local consensus instance using the following code:
```bash
POST -H "Content-type: application/json" -d '<MY_CONTENTS>'
http://localhost:3500/eth/v1/beacon/pool/bls_to_execution_changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on mobile so I don't see the diff well. But are you explaining where this localhost is running? I see you have removed some steps that tell users to log into the node etc.

Copy link
Contributor Author

@fhildeb fhildeb Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explained right below: "3. Log into your node’s terminal and execute the broadcast command on its local consensus interface:"

Good catch- the HTTP is not part of the actual message but rather the destination. I removed it from step 2 and only kept it in step 3 👍🏻

I also added more context to the delay. Ready to be merged now.

@fhildeb fhildeb merged commit 7b247a9 into main Oct 31, 2023
2 checks passed
@fhildeb fhildeb deleted the updated-bls-guide branch October 31, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants