Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a page for LSP1 Type IDs #681

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Create a page for LSP1 Type IDs #681

merged 2 commits into from
Oct 18, 2023

Conversation

b00ste
Copy link
Member

@b00ste b00ste commented Oct 16, 2023

What does this PR introduce?

In this PR we create a page that contains all the LSP1 Type IDs

@Hugoo
Copy link
Contributor

Hugoo commented Oct 16, 2023

Task linked: DEV-8623 Add Type IDs list to the docs.lukso.tech

2 similar comments
@Hugoo
Copy link
Contributor

Hugoo commented Oct 16, 2023

Task linked: DEV-8623 Add Type IDs list to the docs.lukso.tech

@Hugoo
Copy link
Contributor

Hugoo commented Oct 16, 2023

Task linked: DEV-8623 Add Type IDs list to the docs.lukso.tech

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

Deployed with Cloudflare Pages ☁️ 🚀 🆗

CJ42
CJ42 requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the path to this file in the sidebar.js file, so that this page shows in the docs.

image

docs/contracts/type-ids.md Outdated Show resolved Hide resolved
@b00ste b00ste requested a review from Hugoo as a code owner October 18, 2023 09:39
@CJ42 CJ42 merged commit 568537e into main Oct 18, 2023
2 checks passed
@CJ42 CJ42 deleted the DEV-8623 branch October 18, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skimaharvey skimaharvey skimaharvey approved these changes

@CJ42 CJ42 CJ42 approved these changes

@YamenMerhi YamenMerhi Awaiting requested review from YamenMerhi YamenMerhi is a code owner

@Hugoo Hugoo Awaiting requested review from Hugoo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b00ste @Hugoo @CJ42 @skimaharvey